Skip to content

feat(linter): introduce ExternalLinter struct#12052

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/07-03-feat_linter_introduce_externallinter_struct
Jul 3, 2025
Merged

feat(linter): introduce ExternalLinter struct#12052
graphite-app[bot] merged 1 commit intomainfrom
c/07-03-feat_linter_introduce_externallinter_struct

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Jul 3, 2025

No description provided.

@camc314 camc314 mentioned this pull request Jul 3, 2025
Merged
@camc314 camc314 marked this pull request as ready for review July 3, 2025 09:38
@camc314 camc314 requested a review from Sysix as a code owner July 3, 2025 09:38
@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-editor Area - Editor and Language Server C-enhancement Category - New feature or request labels Jul 3, 2025
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Jul 3, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

graphite-app[bot]
graphite-app bot reviewed Jul 3, 2025
View reviewed changes
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 3, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #12052 will improve performances by 15.02%

Comparing c/07-03-feat_linter_introduce_externallinter_struct (f81d336) with main (a257d97)

Summary

⚡ 1 improvements
✅ 37 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ mangler[cal.com.tsx] 3.5 ms 3.1 ms +15.02%

@camc314 camc314 force-pushed the c/07-03-feat_linter_introduce_externallinter_struct branch 2 times, most recently from d702a5b to a3f0e94 Compare July 3, 2025 10:15
@graphite-app graphite-app bot changed the base branch from c/07-03-refactor_linter_mark_napi_lint_as_async to graphite-base/12052 July 3, 2025 10:43
@graphite-app graphite-app bot force-pushed the graphite-base/12052 branch from 33f6645 to f7d998b Compare July 3, 2025 10:51
@graphite-app graphite-app bot force-pushed the c/07-03-feat_linter_introduce_externallinter_struct branch from a3f0e94 to bad4448 Compare July 3, 2025 10:51
@graphite-app graphite-app bot changed the base branch from graphite-base/12052 to main July 3, 2025 10:52
@graphite-app graphite-app bot force-pushed the c/07-03-feat_linter_introduce_externallinter_struct branch from bad4448 to da27091 Compare July 3, 2025 10:52
@camc314 camc314 force-pushed the c/07-03-feat_linter_introduce_externallinter_struct branch from da27091 to b09422c Compare July 3, 2025 11:05
@camc314 camc314 mentioned this pull request Jul 3, 2025
Merged
@camc314 camc314 force-pushed the c/07-03-feat_linter_introduce_externallinter_struct branch from b09422c to a295054 Compare July 3, 2025 17:06
overlookmotel
overlookmotel approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the linker error on Linux, all looks good.

My only comment is that maybe it'd be preferable to keep napi out of oxc_linter crate.

I'm not really clear on where the split of responsibilities is between apps/oxlint and crates/oxc_linter, or why we have that separation. But since we do have that separation, it might be preferable to keep napi stuff in the napi/oxlint2 package.

Could ExternalLinter contain normal tokio async functions, and napi/oxlint2 creates an ExternalLinter containing async functions which call the ThreadsafeFunctions internally?

Note: I don't propose changing this PR, but just a thought for next iteration.

@overlookmotel overlookmotel removed the request for review from Sysix July 3, 2025 19:48
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jul 3, 2025
@overlookmotel Graphite App
Copy link
Member

overlookmotel commented Jul 3, 2025 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the c/07-03-feat_linter_introduce_externallinter_struct branch from a295054 to f81d336 Compare July 3, 2025 19:49
@graphite-app graphite-app bot merged commit f81d336 into main Jul 3, 2025
27 checks passed
@graphite-app graphite-app bot deleted the c/07-03-feat_linter_introduce_externallinter_struct branch July 3, 2025 19:57
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 3, 2025
@oxc-bot oxc-bot mentioned this pull request Jul 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@overlookmotel overlookmotel overlookmotel approved these changes

Assignees

No one assigned

Labels

A-cli Area - CLI A-editor Area - Editor and Language Server A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camc314 @overlookmotel